View Issue Details

IDProjectCategoryView StatusLast Update
0003374ardourbugspublic2020-04-19 20:14
Reporterdanboid Assigned Tooofus  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version3.0-beta1 
Summary0003374: wave/peak not displayed after recording audio track
DescriptionIf I record an audio track into A3 7523 under Debian Squeeze 64 I can see the wave file as its being recorded but as soon as I push stop the peak display goes blank.

Wave/peaks are displayed fine for imported audio, however.
TagsNo tags attached.

Relationships

related to 0003465 new Impoper drawing of waveform 

Activities

oofus

2010-08-01 11:43

developer   ~0008689

I can confirm this. And, if you record on multiple tracks it gets even worse, including wrong size regions and even no regions.

moshisushi

2010-08-01 22:48

reporter   ~0008691

Yeah I mentioned this bug a while ago in #ardour but never got to file a report. So, +1 confirmation.

cth103

2010-08-04 00:01

administrator   ~0008701

The original report should be fixed in SVN. Chris; with that fix I can't reproduce your multiple track problems; do you still see them with current SVN?

Thanks all.

oofus

2010-08-04 00:19

developer   ~0008703

Original post almost fixed. Doesn't work with stereo (and possibly bigger) channels. The left channel shows its waveform on stop but not the right.

As for my part of the report, it was something I saw over the weekend and seemed to get fixed when I updated yesterday. Although I will test a bit more thoroughly to make sure.

oofus

2010-08-04 00:35

developer   ~0008704

Also, after recording a stereo region (or maybe mono as well) zooming in and out doesn't change the size of the waveform, the region itself changes but the waveform stays the same size.

oofus

2010-08-04 00:41

developer   ~0008705

Save and quit the session, then reload it, and the waveforms are shown correctly and zooming resizes the waveform correctly.

moshisushi

2010-08-04 01:24

reporter   ~0008706

Well, it works in mono and stereo for me now, and with multiple tracks.
Zooming while recording seems to work here too in most cases, however, i've had the resize problem that oofus describes on some regions.

danboid

2010-08-04 07:30

reporter   ~0008708

Fixed for me in svn - thank heaven for that as it was surely the most in-your-face visual flaw remaining.

oofus

2010-08-04 10:56

developer   ~0008712

A new session seems to work fine. I think this is fixed.

colinf

2010-08-04 12:39

updater   ~0008715

I've seen this (waveform only shows on left channel of stereo track after recording, and doesn't scale properly when zooming) in 2.0-ongoing occasionally in the last month or two, too, though I haven't found a recipe to reliably reproduce it yet.

It seems to happen most often for me in longer sessions ( > 20 minutes or so) when zoomed all the way out.

I've tried backporting r7534 to 2.0-ongoing: I'll see if it fixes the problem for me there.

2010-08-04 12:45

 

fix-peakfile-display-after-record-2.0-ongoing.patch (929 bytes)   
Index: libs/ardour/audio_diskstream.cc
===================================================================
--- libs/ardour/audio_diskstream.cc	(revision 7534)
+++ libs/ardour/audio_diskstream.cc	(working copy)
@@ -2136,12 +2136,6 @@
 
 	ChannelInfo* chan = (*c)[n];
 	
-	if (chan->write_source) {
-		chan->write_source->done_with_peakfile_writes ();
-		chan->write_source->set_allow_remove_if_empty (true);
-		chan->write_source.reset ();
-	}
-
 	try {
 		if ((chan->write_source = _session.create_audio_source_for_session (*this, n, destructive())) == 0) {
 			throw failed_constructor();
@@ -2176,9 +2170,10 @@
 
 	for (chan = c->begin(), n = 0; chan != c->end(); ++chan, ++n) {
 		if (!destructive()) {
-
 			if ((*chan)->write_source && mark_write_complete) {
 				(*chan)->write_source->mark_streaming_write_completed ();
+				(*chan)->write_source->done_with_peakfile_writes ();
+				
 			}
 			use_new_write_source (n);
 

oofus

2010-08-10 09:17

developer   ~0008782

Original posted issue now fixed.

system

2020-04-19 20:14

developer   ~0022189

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2010-08-01 11:40 danboid New Issue
2010-08-01 11:43 oofus Note Added: 0008689
2010-08-01 22:48 moshisushi Note Added: 0008691
2010-08-02 00:34 cth103 cost => 0.00
2010-08-02 00:34 cth103 Target Version => 3.0-beta1
2010-08-03 23:15 cth103 Status new => confirmed
2010-08-04 00:01 cth103 Note Added: 0008701
2010-08-04 00:01 cth103 Status confirmed => feedback
2010-08-04 00:19 oofus Note Added: 0008703
2010-08-04 00:35 oofus Note Added: 0008704
2010-08-04 00:41 oofus Note Added: 0008705
2010-08-04 01:24 moshisushi Note Added: 0008706
2010-08-04 07:30 danboid Note Added: 0008708
2010-08-04 10:56 oofus Note Added: 0008712
2010-08-04 12:39 colinf Note Added: 0008715
2010-08-04 12:45 colinf File Added: fix-peakfile-display-after-record-2.0-ongoing.patch
2010-08-10 09:17 oofus Note Added: 0008782
2010-08-10 09:17 oofus Status feedback => resolved
2010-08-10 09:17 oofus Resolution open => fixed
2010-08-10 09:17 oofus Assigned To => oofus
2010-09-20 21:18 cth103 Relationship added related to 0003465
2020-04-19 20:14 system Note Added: 0022189
2020-04-19 20:14 system Status resolved => closed