View Issue Details

IDProjectCategoryView StatusLast Update
0008012ardourbugspublic2020-04-14 20:51
Reporterjohmue-eo Assigned Tojohmue-eo  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformSome Other LinuxOSSome Other LinuxOS Versionunknown
Product Version6.0-pre1 
Summary0008012: Ripple drags accross tracks are not correctly undoable.
DescriptionWhen ripple dragging a region to another track and then triggering undo does not move the regions in the original track back where they were.
Steps To Reproduce* Make an empty session
* Add two tracks
* Add at least two audio regions to one of the tracks
* Set Edit Mode to "Ripple"
* Drag the first of the two regions to the other track (this will make the second region come to the left by the length of the first region.
* Trigger undo
Expected: The two regions should be in exact the same position as before the ripple drag
Observed: The region second region remains in the position after the ripple drag.
Additional InformationThis has come up with the fix of 0007007. It has not worked properly before the fix, now it's not working in a different way.

The problem is that when the move to the other track occurs ::remove_unselected_from_views() is called. Then in RegionRippleDrag::finished() we again call remove_unselected_from_views() after ::clear_owned_changes(). That way there are no commands for the movement of the regions in the original track are issued.
TagsNo tags attached.

Activities

johmue-eo

2020-04-14 20:51

developer   ~0021348

Closed as fixed to some extent in d2f5edf. It's still to easy to cause chaos when using ripple edit mode. Bug hunting will go on.

Issue History

Date Modified Username Field Change
2020-04-13 22:27 johmue-eo New Issue
2020-04-13 22:28 johmue-eo Summary Ripple drags accross drags are not correctly undoable. => Ripple drags accross tracks are not correctly undoable.
2020-04-14 20:51 johmue-eo Assigned To => johmue-eo
2020-04-14 20:51 johmue-eo Status new => closed
2020-04-14 20:51 johmue-eo Resolution open => fixed
2020-04-14 20:51 johmue-eo Note Added: 0021348