View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003220 | ardour | bugs | public | 2010-06-03 12:01 | 2020-04-19 20:14 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Target Version | 3.0-beta1 | ||||
| Summary | 0003220: Switching input while recording has unexpected results | ||||
| Description | Switching input while recording causes waveforms not to be shown during recording, and leaves recorded material out of sync. Steps to reproduce: * Record-arm a track connected to system:capture_1 * Start recording * While recording, switch the input to system:capture_2 * Observe that although the signal from system:capture_2 now appears on the meter, no waveform is shown in the regions being recorded. * Stop recording. Waveforms now appear, but the recorded regions, although they appear at the timeline position where recording started, contain audio starting from the instant that the input was switched. Maybe this is just a "don't do that, then" bug, in which case I'd make a feature request to disable switching the input on tracks that are currently recording. | ||||
| Tags | No tags attached. | ||||
| related to | 0003496 | new | capture operation should not depend on track inputs |
|
|
this is definitely a "don't do that then" bug. |
|
|
In which case, please consider it as a feature request :-) |
|
2010-10-06 19:58
|
dont-allow-input-switch-while-recording.patch (357 bytes)
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc (revision 7877)
+++ gtk2_ardour/mixer_strip.cc (working copy)
@@ -648,6 +648,9 @@
return true;
}
+ if (_session.actively_recording() && _route->record_enabled())
+ return true;
+
switch (ev->button) {
case 1:
|
|
|
Here's a minimal patch (against 2.0-ongoing, but applies to 3.0 with some offset too) that prevents the input selector from doing anything on a track that is actively recording. It'd be nicer if it actually disabled the button to give some visual feedback that nothing will happen when the button is clicked, but that's a bit more complicated to do, so I'll leave that to another day. |
|
2010-10-07 17:59
|
dont-allow-input-switch-while-recording-3.0.patch (358 bytes)
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc (revision 7878)
+++ gtk2_ardour/mixer_strip.cc (working copy)
@@ -784,6 +784,9 @@
return true;
}
+ if (_session->actively_recording() && _route->record_enabled())
+ return true;
+
switch (ev->button) {
case 1:
|
|
|
It might apply to 3.0, but it doesn't actually compile. Here's one that does compile, at least... |
|
|
what bizarre use case brought this about one wonders :-| |
|
|
It was more a case of me trying to recover from a mistake: we had a guitarist in overdubbing some lead lines, & I added a new track & started recording onto it in the verse before the lead break, forgetting to choose the correct input first. Not wanting to break his flow (he was already playing along and getting into the music) I switched the input of the track while it was recording, with consequences as above... I'd have been much happier to have discovered straight away that this was a Bad Idea. |
|
|
the patch is committed. there are deeper problems here in that its still clearly possible to change the connectivity using various JACK tools as well. for now, i'm going to mark this resolved and open a new 3.X bug that addresses the deeper issues. |
|
|
see notes |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-06-03 12:01 | colinf | New Issue | |
| 2010-06-03 13:09 | paul | Note Added: 0008145 | |
| 2010-06-03 13:36 | colinf | Note Added: 0008146 | |
| 2010-06-05 10:13 | cth103 | Status | new => confirmed |
| 2010-10-06 19:58 | colinf | File Added: dont-allow-input-switch-while-recording.patch | |
| 2010-10-06 20:03 | colinf | Note Added: 0009211 | |
| 2010-10-07 13:08 | cth103 | cost | => 0.00 |
| 2010-10-07 13:08 | cth103 | Target Version | => 3.0-beta1 |
| 2010-10-07 17:59 | colinf | File Added: dont-allow-input-switch-while-recording-3.0.patch | |
| 2010-10-07 18:01 | colinf | Note Added: 0009219 | |
| 2010-10-07 19:47 | lincoln | Note Added: 0009221 | |
| 2010-10-08 00:09 | colinf | Note Added: 0009222 | |
| 2010-10-08 18:43 | paul | Note Added: 0009223 | |
| 2010-10-08 18:43 | paul | Note Added: 0009224 | |
| 2010-10-08 18:43 | paul | Status | confirmed => resolved |
| 2010-10-08 18:43 | paul | Resolution | open => fixed |
| 2010-10-08 18:43 | paul | Assigned To | => paul |
| 2010-10-08 18:46 | paul | Relationship added | related to 0003496 |
| 2020-04-19 20:14 | system | Note Added: 0022115 | |
| 2020-04-19 20:14 | system | Status | resolved => closed |
