use a monospaced font to display!


Start: we have a single 
region with deactivated 
region fade in/out:        | i                              i |
 
Split 1:                                     v
ok, so far ...             | i             i | i            i |

now:
drag region fade in:                         .>>>.
the fade in of the second  | i             i | a            i |
region is automatically 
activated. that's ok.

now split the second 
region, again:                                        v
Error: the beginning of    | i             i | a     i|A    i |
the now 3rd region has an
activated fade in!

Now let's undo this step 
by step: undo 2nd split    | A             A | a            A |
ERROR: expected is:        | i             i | a     i|A    i |
 
      
all further undo steps now 
contain wrong fade in/out                    .<<<.
activation state, undo drag| A             A | A            A |
ERROR: expected is:        | i             i | i            i |

undo 1st split:            | A                              A |
ERROR: expected is:        | i                              i |

diff --git a/libs/ardour/audioregion.cc b/libs/ardour/audioregion.cc
index 6163897..80ede2a 100644
--- a/libs/ardour/audioregion.cc
+++ b/libs/ardour/audioregion.cc
@@ -724,7 +724,7 @@ AudioRegion::state (bool full)
 			child->add_child_nocopy (_fade_in.get_state ());
 		}
 
-		child->add_property (X_("active"), _fade_in_disabled ? X_("no") : X_("yes"));
+		child->add_property (X_("active"), fade_in_active () ? X_("yes") : X_("no"));
 		
 		child = node.add_child (X_("FadeOut"));
 		
@@ -734,7 +734,7 @@ AudioRegion::state (bool full)
 			child->add_child_nocopy (_fade_out.get_state ());
 		}
 		
-		child->add_property (X_("active"), _fade_out_disabled ? X_("no") : X_("yes"));
+		child->add_property (X_("active"), fade_out_active () ? X_("yes") : X_("no"));
 	}
 	
 	child = node.add_child ("Envelope");
@@ -850,7 +850,7 @@ AudioRegion::set_live_state (const XMLNode& node, Change& what_changed, bool sen
 				if (string_is_affirmative (prop->value())) {
 					set_fade_in_active (true);
 				} else {
-					set_fade_in_active (true);
+					set_fade_in_active (false);
 				}
 			}
 

Index: libs/ardour/playlist.cc
===================================================================
--- libs/ardour/playlist.cc	(Revision 5997)
+++ libs/ardour/playlist.cc	(Arbeitskopie)
@@ -1106,6 +1106,19 @@
 	_split_region (region, playlist_position);
 }
 
+static void deactivate_fade(boost::shared_ptr<Region> region, bool fade_in) 
+{
+	boost::shared_ptr<AudioRegion> other;
+
+	if ((other = boost::dynamic_pointer_cast<AudioRegion>(region)) != 0) {
+		if(fade_in) {
+		  	other->set_fade_in_active(false);
+		} else {
+		  	other->set_fade_out_active(false);
+		}
+	}
+}
+
 void
 Playlist::_split_region (boost::shared_ptr<Region> region, nframes_t playlist_position)
 {
@@ -1135,9 +1148,11 @@
 	
 	_session.region_name (before_name, region->name(), false);
 	left = RegionFactory::create (region, 0, before, before_name, region->layer(), Region::Flag (region->flags()|Region::LeftOfSplit));
+	deactivate_fade(left, false);
 
 	_session.region_name (after_name, region->name(), false);
 	right = RegionFactory::create (region, before, after, after_name, region->layer(), Region::Flag (region->flags()|Region::RightOfSplit));
+	deactivate_fade(right, true);
 
 	add_region_internal (left, region->position());
 	add_region_internal (right, region->position() + before);