View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008642 | ardour | bugs | public | 2021-03-29 08:26 | 2021-05-28 08:26 |
| Reporter | johne53 | Assigned To | x42 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Microsoft | OS | Windows | OS Version | 10 |
| Product Version | Mixbus 6.x | ||||
| Summary | 0008642: VST3 plugin crash (DMG Limitless) | ||||
| Description | Over on the Mixbus forum someone's found a VST3 plugin called "DMG Limitless" that consistently crashes Mixbus:- https://forum.harrisonconsoles.com/thread-10049.html I took a look at the code here and it crashes at line 2291 in 'libs/ardour/vst3_plugin.cc':- tresult res = _controller->setState (&stream); I'm not quite sure what I'm doing here but if I change that code and borrow a bit from a few lines earlier, it seems to work - in other words I remove the above line and replace it, using these two lines:- ROMStream s(stream, i->_offset, i->_size); tresult res = _component->setState(&s); Just wondering if that makes any sense to you guys..? | ||||
| Steps To Reproduce | Add the "DMG Limitless" plugin to any channel or bus. Close the session and simply try to re-open it, | ||||
| Additional Information | DMG Limitless also offers a VST2 version which can be used as a workaround | ||||
| Tags | No tags attached. | ||||
|
|
Nice find! This is a bug in the plugin. softube had a similar issue, we reported up and they meanwhile fixed it. Usually plugins are supposed to wrap the stream, like "IBStreamer" in https://github.com/steinbergmedia/vst3_public_sdk/blob/master/samples/vst/again/source/againcontroller.cpp#L195-L217 As workaround we can apply your patch. It doesn't hurt and we've done it as stopgap for other plugins. |
|
|
Applied as 6.6-222-geebe4e467b Thank you! |
|
|
johne53 , maybe it would be good to point out in the harrison forum that it's a plugin's bug, and you, the Ardour devs, just created a workaround for it :) |
|
|
Done !! |
|
|
@mikelupe I think it's a bad idea to blame on a public forum. Nobody benefits and it is not healthy for a user community. Especially technical issues like this are are best kept on a tech platform (bug trackers etc). |
|
|
@x42 I totally agree. But let me give a "but": I didn't think it was healthy to give the impression, that Ardour was to blame. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-03-29 08:26 | johne53 | New Issue | |
| 2021-03-29 12:43 | x42 | Note Added: 0025652 | |
| 2021-03-29 12:48 | x42 | Assigned To | => x42 |
| 2021-03-29 12:48 | x42 | Status | new => resolved |
| 2021-03-29 12:48 | x42 | Resolution | open => fixed |
| 2021-03-29 12:48 | x42 | Note Added: 0025653 | |
| 2021-03-29 14:30 | mikelupe | Note Added: 0025654 | |
| 2021-03-29 14:46 | johne53 | Note Added: 0025655 | |
| 2021-03-29 14:55 | x42 | Note Added: 0025656 | |
| 2021-03-29 15:03 | mikelupe | Note Added: 0025657 | |
| 2021-05-28 08:26 | anonymous | Note Added: 0025902 | |
| 2021-05-28 08:26 | anonymous | Status | resolved => closed |
